Skip to content

fish: disable more flaky tests#477300

Merged
winterqt merged 1 commit intoNixOS:masterfrom
adamcstephens:push-kkylvkmtzryn
Jan 5, 2026
Merged

fish: disable more flaky tests#477300
winterqt merged 1 commit intoNixOS:masterfrom
adamcstephens:push-kkylvkmtzryn

Conversation

@adamcstephens
Copy link
Contributor

@adamcstephens adamcstephens commented Jan 5, 2026

fish-shell/fish-shell#12253 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@adamcstephens adamcstephens mentioned this pull request Jan 5, 2026
Closed
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Jan 5, 2026
winterqt
winterqt approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks.

@winterqt winterqt added the backport release-25.11 Backport PR automatically label Jan 5, 2026
@winterqt winterqt added this pull request to the merge queue Jan 5, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 5, 2026
Merged via the queue into NixOS:master with commit a5bcd28 Jan 5, 2026
33 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 5, 2026

Successfully created backport PR for release-25.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 5, 2026
Merged
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jan 5, 2026
@adamcstephens adamcstephens deleted the push-kkylvkmtzryn branch January 5, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winterqt winterqt winterqt approved these changes

@cole-h cole-h Awaiting requested review from cole-h

@lonerOrz lonerOrz Awaiting requested review from lonerOrz

@r-vdp r-vdp Awaiting requested review from r-vdp

@SigmaSquadron SigmaSquadron Awaiting requested review from SigmaSquadron

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamcstephens @winterqt